Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: fail-exit when 0 signatures are loaded from a collection #282

Merged
merged 3 commits into from
Mar 20, 2024
Merged

MRG: fail-exit when 0 signatures are loaded from a collection #282

merged 3 commits into from
Mar 20, 2024

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Mar 20, 2024 •
edited
Loading

Error out when 0 signatures are loaded from a collection.

Since we currently only load a single collection as our query or database, 0 sigs in either means that no useful results would be obtained.

@bluegenes bluegenes changed the title WIP: fail-exit when 0 signatures are loaded from a collection MRG: fail-exit when 0 signatures are loaded from a collection Mar 20, 2024
@bluegenes
Copy link
Contributor Author

@ctb ready for review!

@bluegenes bluegenes mentioned this pull request Mar 20, 2024
Merged
@bluegenes bluegenes reopened this Mar 20, 2024
@bluegenes bluegenes merged commit 4004e85 into main Mar 20, 2024
1 check passed
@bluegenes bluegenes deleted the err-on-0-load branch March 20, 2024 21:30
@ctb ctb mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctb ctb ctb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index:: do not write output if no signatures to write?
2 participants
@bluegenes @ctb